uniform color handling between labels and points/shapes#497
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
=======================================
Coverage 84.00% 84.01%
=======================================
Files 9 9
Lines 2601 2608 +7
=======================================
+ Hits 2185 2191 +6
- Misses 416 417 +1
🚀 New features to boost your workflow:
|
timtreis
reviewed
Oct 20, 2025
timtreis
force-pushed
the
feature/refactor_label_color_handling
branch
3 times, most recently
from
6338980 to
c31d2e9
Compare
- Use `is not None` instead of truthiness check, matching shapes/points - Pass overridden na_color to _map_color_seg so labels not in the table respect the literal color when one is set Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When color is a literal value (not a column name), the groups parameter has no effect. Added a warning for labels, points, and shapes so users aren't silently confused. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Extract duplicated groups-ignored warning string to _GROUPS_IGNORED_WARNING - Add col_for_color guard to na_color override, matching the points pattern Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
timtreis
force-pushed
the
feature/refactor_label_color_handling
branch
from
b17fad5 to
35014ff
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Change `color: str | None` to `color: ColorLike | None` in render_labels signature and _validate_label_render_params to match render_shapes/render_points - Update docstring to document that color-like values (named colors, hex strings, RGB(A) tuples) are accepted as literal colors - Add tests for hex string and RGBA tuple color inputs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The palette/groups gating logic (set to None when col_for_color is absent, warn when groups is provided without a column) was repeated identically in _validate_label_render_params, _validate_points_render_params, and _validate_shape_render_params. Extracted into a shared helper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ility Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change fill_alpha default from 0.4 to None so that _type_check_params can extract the alpha from an RGBA color tuple, matching how points and shapes already handle this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the 3 ad-hoc tests (color_name, hex, rgba_tuple) with 4 tests that mirror the existing points and shapes pattern: rgba_array, hex, hex_with_alpha, and alpha_overwrites_opacity_from_color. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #478, here we adapt the color handling of labels so that it works the same way as points/shapes (e.g. you can pass any color like...)